Closed
Bug 1073498
Opened 11 years ago
Closed 10 years ago
Use alert screen prompt when the user is no logged-in and try make a call from contact details (Follow-up of bug 1070860)
Categories
(Firefox OS Graveyard :: Gaia::Loop, enhancement)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: oteo, Assigned: macajc)
References
Details
(Whiteboard: [mobile app][tef-triage][not blocking][loop not in 1.1] )
Attachments
(3 files, 2 obsolete files)
According to the feedback provided by UX team in bug 1070860, when a user (not logged-in Loop) wants to call to another from contact details (inside the Contact application) the prompt screen including the error message should be an alert one (not a confirmation as it's implemented now)
https://bug1070860.bugzilla.mozilla.org/attachment.cgi?id=8492998
With two buttons, one for canceling and one for logging in
Reporter | ||
Updated•11 years ago
|
Severity: normal → enhancement
Summary: (Follow-up of bug 1070860) → Use alert screen prompt when the user is no logged-in and try make a call from contact details (Follow-up of bug 1070860)
Whiteboard: [mobile app][tef-triage][not blocking]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → carmen.jimenezcabezas
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8508289 -
Flags: review?(monica.meika)
Assignee | ||
Updated•10 years ago
|
Attachment #8508291 -
Flags: review?(monica.meika)
Assignee | ||
Updated•10 years ago
|
Attachment #8508286 -
Flags: review?(josea.olivera)
Comment 4•10 years ago
|
||
Comment on attachment 8508289 [details]
screenshot - EN
String: "You need to be logged in to use Firefox Hello"
Thanks.
Attachment #8508289 -
Flags: review?(monica.meika) → review-
Comment 5•10 years ago
|
||
Comment on attachment 8508291 [details]
screenshot - ES
String: "Tienes que iniciar sesión para acceder a Firefox Hello".
Two buttons below => [Ok] [Iniciar sesión].
Thanks.
Attachment #8508291 -
Flags: review?(monica.meika) → review-
Assignee | ||
Comment 6•10 years ago
|
||
I've preserved the text which was landed in bug 1070860. I've only added the buttons but, if you think I should changed it I'll do it (sure!),
Flags: needinfo?(monica.meika)
Comment 7•10 years ago
|
||
Yes, please.
And, sorry: "Necesitas iniciar sesión para usar Firefox Hello" in spanish, please :)
Thanks.
Flags: needinfo?(monica.meika)
Comment 8•10 years ago
|
||
(In reply to Mónica UX/UI from comment #7)
> Yes, please.
>
> And, sorry: "Necesitas iniciar sesión para usar Firefox Hello" in spanish,
> please :)
> Thanks.
Remove [Ok] and add [Cancel] or [Cancelar]
Thanks.
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8508289 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8508291 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8508580 -
Flags: review?(monica.meika)
Assignee | ||
Updated•10 years ago
|
Attachment #8508581 -
Flags: review?(monica.meika)
Updated•10 years ago
|
Attachment #8508580 -
Flags: review?(monica.meika) → review+
Updated•10 years ago
|
Attachment #8508581 -
Flags: review?(monica.meika) → review+
Assignee | ||
Comment 11•10 years ago
|
||
The screen at [1] doesn't have a loop header (same as the logout window, actually). Should we add a header to the screen at [1] or are you all right with that screen not having a header?
[1]: https://bug1073498.bugzilla.mozilla.org/attachment.cgi?id=8508580
Flags: needinfo?(monica.meika)
Comment 12•10 years ago
|
||
Comment on attachment 8508286 [details] [review]
V1 Proposed patch
The code LGTM, left a few comments on the PR. Nothing crazy, just a few nits here and there. Address them and request review at me again once the UX team gives feedback about the headers thing you asked. Thanks Carmen!
Attachment #8508286 -
Flags: review?(josea.olivera) → feedback+
Comment 13•10 years ago
|
||
Hi Carmen.
I think that it's ok the screen without screen.
Flags: needinfo?(monica.meika)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8508286 [details] [review]
V1 Proposed patch
I made some of the changes the requested, and answered the rest. Can you take a look again? Thanks!!!
Attachment #8508286 -
Flags: review?(josea.olivera)
Comment 15•10 years ago
|
||
Comment on attachment 8508286 [details] [review]
V1 Proposed patch
LGTM. r=me
Thanks for addressing the comments and making clear all the doubts. Did kind of smoke test and It seems it works as expected and nothing gets broken.
Thanks for taking care of it Carmen.
PS. Rebase and land at will please.
Attachment #8508286 -
Flags: review?(josea.olivera) → review+
Assignee | ||
Comment 16•10 years ago
|
||
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/01b9d3fcbc8030077c7fa98a2c24c50a0f0f479a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Whiteboard: [mobile app][tef-triage][not blocking] → [mobile app][tef-triage][not blocking][loop not in 1.1]
Comment 17•10 years ago
|
||
Tested with German,English and Spanish languaje selected.
Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•